netdev - Re: [PATCH v2 net-next] bnxt: convert EEE handling to use linkmode bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a52c2a77-4d0c-48a9-88ea-3ec301212b31@gmail.com>
Date: Wed, 7 Feb 2024 11:43:39 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, David Miller <davem@...emloft.net>,
 Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
 Russell King - ARM Linux <linux@...linux.org.uk>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 Andrew Lunn <andrew@...n.ch>, Michael Chan <michael.chan@...adcom.com>
Subject: Re: [PATCH v2 net-next] bnxt: convert EEE handling to use linkmode
 bitmaps

On 04.02.2024 00:09, Heiner Kallweit wrote:
> Convert EEE handling to use linkmode bitmaps. This prepares for removing
> the legacy bitmaps from struct ethtool_keee. No functional change
> intended. When replacing _bnxt_fw_to_ethtool_adv_spds() with
> _bnxt_fw_to_linkmode(), remove the fw_pause argument because it's
> always passed as 0.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
> v2:
> - add missing conversions
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 21 +++---
>  .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 65 ++++++++-----------
>  .../net/ethernet/broadcom/bnxt/bnxt_ethtool.h |  4 +-
>  3 files changed, 40 insertions(+), 50 deletions(-)
> 
This patch has been set to "Not applicable" in patchwork. Why that?

The follow-up discussion with Michael on how exactly certain EEE
aspects are handled in the driver is independent of the mechanical
conversion in this patch. As stated in the commit message this patch
doesn't change functionality.