netdev - Re: [PATCH net] selftests: bonding: fix macvlan2's namespace name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 7 Feb 2024 09:45:49 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
	"David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>, Liang Li <liali@...hat.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH net] selftests: bonding: fix macvlan2's namespace name

On Tue, Feb 06, 2024 at 03:35:15PM +0000, Simon Horman wrote:
> On Sun, Feb 04, 2024 at 04:38:28PM +0800, Hangbin Liu wrote:
> > The m2's ns name should be m2-xxxxxx, not m1.
> > 
> > Fixes: 246af950b940 ("selftests: bonding: add macvlan over bond testing")
> > Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> 
> Hi Hangbin Liu,
> 
> I agree this is a nice change.
> But it is not clear to me that this is fixing a bug.

Ah, you are right. I also just realise that the previous code also
works as we use mktemp, so the m1 and m2's name are unique, although
the m2's name using m1 as prefix.

Please feel free to drop this patch. I can do the name modification in future
when updating the bond_macvlan test.

Thanks
Hangbin

> 
> > ---
> >  tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
> > index dc99e4ac262e..969bf9af1b94 100755
> > --- a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
> > +++ b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
> > @@ -7,7 +7,7 @@ lib_dir=$(dirname "$0")
> >  source ${lib_dir}/bond_topo_2d1c.sh
> >  
> >  m1_ns="m1-$(mktemp -u XXXXXX)"
> > -m2_ns="m1-$(mktemp -u XXXXXX)"
> > +m2_ns="m2-$(mktemp -u XXXXXX)"
> >  m1_ip4="192.0.2.11"
> >  m1_ip6="2001:db8::11"
> >  m2_ip4="192.0.2.12"
> > -- 
> > 2.43.0
> > 
> >