netdev - Re: [PATCH resubmit] net: fec: Add ECR bit macros, fix FEC_ECR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 7 Feb 2024 15:55:46 +0100
From: Csókás Bence <csokas.bence@...lan.hu>
To: Andrew Lunn <andrew@...n.ch>
CC: <netdev@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>, "David S.
 Miller" <davem@...emloft.net>, Wei Fang <wei.fang@....com>, Shenwei Wang
	<shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>, NXP Linux Team
	<linux-imx@....com>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
	<pabeni@...hat.com>, Francesco Dolcini <francesco.dolcini@...adex.com>, "Marc
 Kleine-Budde" <mkl@...gutronix.de>
Subject: Re: [PATCH resubmit] net: fec: Add ECR bit macros, fix FEC_ECR_EN1588
 being cleared on link-down



2024. 02. 07. 15:44 keltezéssel, Andrew Lunn írta:
> On Wed, Feb 07, 2024 at 01:36:11PM +0100, Csókás Bence wrote:
>> FEC_ECR_EN1588 bit gets cleared after MAC reset in `fec_stop()`, which
>> makes all 1588 functionality shut down on link-down. However, some
>> functionality needs to be retained (e.g. PPS) even without link.
> 
> This is the second version of the patch, so the subject should say v2
> within the [PATCH ].

This is the same as the other, just added the rationale text to the 
message body.

> Is this fixing a regression, or did it never work correctly?

PTP on this family of Ethernet controllers is utterly broken. See commit 
f79959220fa5fbda939592bf91c7a9ea90419040 (reverted). I plan on 
re-submitting that entire patch, if i can figure out the locking 
problems that have arisen.

> Please could you split this into two patches. The first patch
> introduced the new #defines, and uses them in the existing code. That
> should be obviously correct. And a second patch adding the new
> functionality, with a good commit message explaining the change,
> particularly the Why?

Sure.

> There was a request to keep the indentation the same. So the BIT()
> need moving right.

> Reverse Christmas tree, as pointed out in your first version of the
> patch.

Ah, sorry, I missed those. Also can do.

> Thanks
>      Andrew
> 
> ---
> pw-bot: cr
> 

Bence