netdev - Re: [PATCH v2 RESUBMIT net-next] bnxt: convert EEE handling to use linkmode bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLikdfRxHpuWipNViR8_LTEeE0d=xdRtmNApoAkr_gJ0VvQ@mail.gmail.com>
Date: Wed, 7 Feb 2024 10:07:44 -0800
From: Michael Chan <michael.chan@...adcom.com>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, David Miller <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>, 
	Russell King - ARM Linux <linux@...linux.org.uk>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 RESUBMIT net-next] bnxt: convert EEE handling to use
 linkmode bitmaps

On Wed, Feb 7, 2024 at 8:47 AM Heiner Kallweit <hkallweit1@...il.com> wrote:
>
> Convert EEE handling to use linkmode bitmaps. This prepares for removing
> the legacy bitmaps from struct ethtool_keee. No functional change
> intended. When replacing _bnxt_fw_to_ethtool_adv_spds() with
> _bnxt_fw_to_linkmode(), remove the fw_pause argument because it's
> always passed as 0.
>
> Note:
> There's a discussion on whether the underlying implementation is correct,
> but it's independent of this mechanical conversion w/o functional change.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Thanks.
Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)