netdev - Re: [PATCH v2 net] ps3/gelic: Fix SKB allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240206185227.5c167ea5@kernel.org>
Date: Tue, 6 Feb 2024 18:52:27 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Geoff Levand <geoff@...radead.org>
Cc: sambat goson <sombat3960@...il.com>, Christophe Leroy
 <christophe.leroy@...roup.eu>, Paolo Abeni <pabeni@...hat.com>, "David S.
 Miller" <davem@...emloft.net>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net] ps3/gelic: Fix SKB allocation

On Mon, 5 Feb 2024 10:48:07 +0900 Geoff Levand wrote:
>     Commit 3ce4f9c3fbb3 ("net/ps3_gelic_net: Add gelic_descr structures")
>     of 6.8-rc1 did not set up the network SKB's correctly, resulting in
>     a kernel panic.
>     
>     This fix changes the way the napi buffer and corresponding SKB are
>     allocated and managed.
>     
>     Reported-by: sambat goson <sombat3960@...il.com>
>     Fixes: 3ce4f9c3fbb3 ("net/ps3_gelic_net: Add gelic_descr structures")
>     Signed-off-by: Geoff Levand <geoff@...radead.org>

Please make the commit message describe the problem in more detail.
It's also indented for no reason.