netdev - [PATCH] ipaddrlabel: Fix descriptor leak in flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Wed,  7 Feb 2024 23:25:42 +0300
From: Maks Mishin <maks.mishinfz@...il.com>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: Maks Mishin <maks.mishinFZ@...il.com>,
	netdev@...r.kernel.org
Subject: [PATCH] ipaddrlabel: Fix descriptor leak in flush_addrlabel()

Added closure of descriptor `rth2.fd` created by rtnl_open() when
returning from function.

Signed-off-by: Maks Mishin <maks.mishinFZ@...il.com>
---
 ip/ipaddrlabel.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ip/ipaddrlabel.c b/ip/ipaddrlabel.c
index b045827a..3857fcf5 100644
--- a/ip/ipaddrlabel.c
+++ b/ip/ipaddrlabel.c
@@ -201,8 +201,10 @@ static int flush_addrlabel(struct nlmsghdr *n, void *arg)
 		n->nlmsg_type = RTM_DELADDRLABEL;
 		n->nlmsg_flags = NLM_F_REQUEST;
 
-		if (rtnl_open(&rth2, 0) < 0)
+		if (rtnl_open(&rth2, 0) < 0) {
+			rtnl_close(&rth2);
 			return -1;
+		}
 
 		if (rtnl_talk(&rth2, n, NULL) < 0)
 			return -2;
-- 
2.30.2