netdev - Re: [PATCH] net: ethernet: remove duplicated CONFIG_SUNGEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <da0e7982-9aa7-4b02-97da-7f580085a1d6@lunn.ch>
Date: Thu, 8 Feb 2024 00:39:01 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Simon Horman <horms@...nel.org>
Cc: Masahiro Yamada <masahiroy@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: remove duplicated CONFIG_SUNGEM_PHY entry

On Tue, Feb 06, 2024 at 05:41:30PM +0000, Simon Horman wrote:
> On Sun, Feb 04, 2024 at 09:31:51PM +0900, Masahiro Yamada wrote:
> > Both drivers/net/Kconfig and drivers/net/ethernet/Kconfig contain the
> > same config entry:
> > 
> >   config SUNGEM_PHY
> >           tristate
> > 
> > Commit f860b0522f65 ("drivers/net: Kconfig and Makefile cleanup") moved
> > SUNGEM_PHY from drivers/net/Kconfig to drivers/net/ethernet/Kconfig.
> > 
> > Shortly after it was applied, commit 19e2f6fe9601 ("net: Fix sungem_phy
> > sharing.") added the second one to drivers/net/Kconfig.
> > 
> > I kept the one in drivers/net/Kconfig because this CONFIG option controls
> > the compilation of drivers/net/sungem_phy.c.
> > 
> > Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> 
> Thanks Yamada-san,
> 
> This looks good to me as-is,
> but I guess a follow-up question is if sungem_phy.c
> should move to drivers/net/phy.

It is not a phylib PHY driver. So i would say no.

It would however be nice to port the MAC drivers using this to
phylib. The PHY devices this sungem_phy.c supports don't look
particularly exotic, just Marvell and Broadcom PHYs which phylib
probably already supports.

	 Andrew