| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CANn89iKQ6-MY2KtPU79P8RTZDc7D_Wp8h6F2+io1ab9E1kn3zQ@mail.gmail.com>
Date: Thu, 8 Feb 2024 14:35:07 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: kernel test robot <lkp@...el.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 10/13] net: add netdev_set_operstate() helper
On Thu, Feb 8, 2024 at 2:20 PM kernel test robot <lkp@...el.com> wrote:
>
> Hi Eric,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on net-next/main]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/net-annotate-data-races-around-dev-name_assign_type/20240207-222903
> base: net-next/main
> patch link: https://lore.kernel.org/r/20240207142629.3456570-11-edumazet%40google.com
> patch subject: [PATCH net-next 10/13] net: add netdev_set_operstate() helper
> config: riscv-defconfig (https://download.01.org/0day-ci/archive/20240208/202402082151.O18ZoLSK-lkp@intel.com/config)
> compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 7dd790db8b77c4a833c06632e903dc4f13877a64)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240208/202402082151.O18ZoLSK-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202402082151.O18ZoLSK-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> >> net/core/rtnetlink.c:852:12: error: call to '__compiletime_assert_784' declared with 'error' attribute: BUILD_BUG failed
> 852 | } while (!try_cmpxchg(&dev->operstate, &old, newstate));
> | ^
> include/linux/atomic/atomic-instrumented.h:4838:2: note: expanded from macro 'try_cmpxchg'
> 4838 | raw_try_cmpxchg(__ai_ptr, __ai_oldp, __VA_ARGS__); \
> | ^
> include/linux/atomic/atomic-arch-fallback.h:192:9: note: expanded from macro 'raw_try_cmpxchg'
> 192 | ___r = raw_cmpxchg((_ptr), ___o, (_new)); \
> | ^
> include/linux/atomic/atomic-arch-fallback.h:55:21: note: expanded from macro 'raw_cmpxchg'
> 55 | #define raw_cmpxchg arch_cmpxchg
> | ^
> note: (skipping 5 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
> include/linux/compiler_types.h:423:2: note: expanded from macro '_compiletime_assert'
> 423 | __compiletime_assert(condition, msg, prefix, suffix)
> | ^
> include/linux/compiler_types.h:416:4: note: expanded from macro '__compiletime_assert'
> 416 | prefix ## suffix(); \
> | ^
> <scratch space>:50:1: note: expanded from here
> 50 | __compiletime_assert_784
> | ^
> >> net/core/rtnetlink.c:852:12: error: call to '__compiletime_assert_784' declared with 'error' attribute: BUILD_BUG failed
> include/linux/atomic/atomic-instrumented.h:4838:2: note: expanded from macro 'try_cmpxchg'
> 4838 | raw_try_cmpxchg(__ai_ptr, __ai_oldp, __VA_ARGS__); \
> | ^
> include/linux/atomic/atomic-arch-fallback.h:192:9: note: expanded from macro 'raw_try_cmpxchg'
> 192 | ___r = raw_cmpxchg((_ptr), ___o, (_new)); \
> | ^
> include/linux/atomic/atomic-arch-fallback.h:55:21: note: expanded from macro 'raw_cmpxchg'
> 55 | #define raw_cmpxchg arch_cmpxchg
> | ^
> note: (skipping 5 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
> include/linux/compiler_types.h:423:2: note: expanded from macro '_compiletime_assert'
> 423 | __compiletime_assert(condition, msg, prefix, suffix)
> | ^
> include/linux/compiler_types.h:416:4: note: expanded from macro '__compiletime_assert'
> 416 | prefix ## suffix(); \
> | ^
> <scratch space>:50:1: note: expanded from here
> 50 | __compiletime_assert_784
> | ^
> >> net/core/rtnetlink.c:852:12: error: call to '__compiletime_assert_784' declared with 'error' attribute: BUILD_BUG failed
> include/linux/atomic/atomic-instrumented.h:4838:2: note: expanded from macro 'try_cmpxchg'
> 4838 | raw_try_cmpxchg(__ai_ptr, __ai_oldp, __VA_ARGS__); \
> | ^
> include/linux/atomic/atomic-arch-fallback.h:192:9: note: expanded from macro 'raw_try_cmpxchg'
> 192 | ___r = raw_cmpxchg((_ptr), ___o, (_new)); \
> | ^
> include/linux/atomic/atomic-arch-fallback.h:55:21: note: expanded from macro 'raw_cmpxchg'
> 55 | #define raw_cmpxchg arch_cmpxchg
> | ^
> note: (skipping 5 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
> include/linux/compiler_types.h:423:2: note: expanded from macro '_compiletime_assert'
> 423 | __compiletime_assert(condition, msg, prefix, suffix)
> | ^
> include/linux/compiler_types.h:416:4: note: expanded from macro '__compiletime_assert'
> 416 | prefix ## suffix(); \
> | ^
> <scratch space>:50:1: note: expanded from here
> 50 | __compiletime_assert_784
> | ^
> 3 errors generated.
>
>
> vim +852 net/core/rtnetlink.c
>
> 844
> 845 void netdev_set_operstate(struct net_device *dev, int newstate)
> 846 {
> 847 unsigned char old = READ_ONCE(dev->operstate);
> 848
> 849 do {
> 850 if (old == newstate)
> 851 return;
> > 852 } while (!try_cmpxchg(&dev->operstate, &old, newstate));
> 853
> 854 netdev_state_change(dev);
> 855 }
> 856 EXPORT_SYMBOL(netdev_set_operstate);
> 857
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
Ok, some arches are unable to perform cmpxchg() on u8, only plain
32bit integers.
I will send a v2 then.
Powered by blists - more mailing lists