netdev - Re: [PATCH net v2] selftests: net: Fix bridge backup port test flakiness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d79627f676484590eac5f6b54758ab315f316fc.camel@redhat.com>
Date: Thu, 08 Feb 2024 17:54:47 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org, 
	linux-kselftest@...r.kernel.org
Cc: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com, 
	razor@...ckwall.org, shuah@...nel.org, petrm@...dia.com
Subject: Re: [PATCH net v2] selftests: net: Fix bridge backup port test
 flakiness

On Thu, 2024-02-08 at 14:31 +0200, Ido Schimmel wrote:
> The test toggles the carrier of a bridge port in order to test the
> bridge backup port feature.
> 
> Due to the linkwatch delayed work the carrier change is not always
> reflected fast enough to the bridge driver and packets are not forwarded
> as the test expects, resulting in failures [1].
> 
> Fix by busy waiting on the bridge port state until it changes to the
> desired state following the carrier change.
> 
> [1]
>  # Backup port
>  # -----------
>  [...]
>  # TEST: swp1 carrier off                                              [ OK ]
>  # TEST: No forwarding out of swp1                                     [FAIL]
>  [  641.995910] br0: port 1(swp1) entered disabled state
>  # TEST: No forwarding out of vx0                                      [ OK ]
> 
> Fixes: b408453053fb ("selftests: net: Add bridge backup port and backup nexthop ID test")
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> Reviewed-by: Petr Machata <petrm@...dia.com>
> ---
> 
> Notes:
>     v2:
>     * Use busy waiting instead of 1 second sleep.

Fine by be, thanks!

Acked-by: Paolo Abeni <pabeni@...hat.com>