netdev - Re: [PATCH net-next] selftests: net: ignore timing errors in txtimestamp if KSFT_MACHINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 08 Feb 2024 18:46:48 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, 
 Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: Paolo Abeni <pabeni@...hat.com>, 
 netdev@...r.kernel.org, 
 "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Shuah Khan <shuah@...nel.org>, 
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: net: ignore timing errors in
 txtimestamp if KSFT_MACHINE_SLOW

Jakub Kicinski wrote:
> On Thu, 08 Feb 2024 15:51:31 -0500 Willem de Bruijn wrote:
> > Paolo Abeni wrote:
> > > This test is time sensitive. It may fail on virtual machines and for
> > > debug builds.
> > > 
> > > Similar to commit c41dfb0dfbec ("selftests/net: ignore timing errors in
> > > so_txtime if KSFT_MACHINE_SLOW"), optionally suppress failure for timing
> > > errors (only).
> > > 
> > > Signed-off-by: Paolo Abeni <pabeni@...hat.com>  
> > 
> > Is this still failing after commit 5264ab612e28
> > ("selftests/net: calibrate txtimestamp")?
> 
> On a debug kernel it continues to flake :(
> 
> https://netdev.bots.linux.dev/flakes.html?br-cnt=80&tn-needle=txtimestamp&min-flip=0

Thanks. I should have checked the dash directly. Reminder for next time.

Reviewed-by: Willem de Bruijn <willemb@...gle.com>