netdev - Re: [net-next PATCH v2] octeontx2: Add PTP clock driver for Octeon PTM clock.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240208185130.23509cb3@kernel.org>
Date: Thu, 8 Feb 2024 18:51:30 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Sai Krishna <saikrishnag@...vell.com>
Cc: <richardcochran@...il.com>, <horms@...nel.org>,
 <vinicius.gomes@...el.com>, <vadim.fedorenko@...ux.dev>,
 <davem@...emloft.net>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <sgoutham@...vell.com>,
 <gakula@...vell.com>, <lcherian@...vell.com>, <hkelam@...vell.com>,
 <sbhatta@...vell.com>, Naveen Mamindlapalli <naveenm@...vell.com>
Subject: Re: [net-next PATCH v2] octeontx2: Add PTP clock driver for Octeon
 PTM clock.

On Tue, 6 Feb 2024 23:40:09 +0530 Sai Krishna wrote:
> The PCIe PTM(Precision time measurement) protocol provides precise
> coordination of events across multiple components like PCIe host
> clock, PCIe EP PHC local clocks of PCIe devices. This patch adds
> support for ptp clock based PTM clock. We can use this PTP device
> to sync the PTM time with CLOCK_REALTIME or other PTP PHC
> devices using phc2sys.

A bit of an odd driver, somewhat similar to what Amazon described.
You register a PTP clock but there's no PTP involved. Also you call
pci_get_device() instead of binding to a proper bus.

Please repost this, add linux-pci and the PCI maintainers to the CC.
It'd be great to get their acks (in addition to Richard's).
-- 
pw-bot: cr