netdev - Re: [PATCH net-next 3/6] bridge: vlan: use synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 9 Feb 2024 18:25:09 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: David Ahern <dsahern@...nel.org>, Pablo Neira Ayuso
 <pablo@...filter.org>, Florian Westphal <fw@...len.de>,
 netdev@...r.kernel.org, eric.dumazet@...il.com,
 Roopa Prabhu <roopa@...dia.com>
Subject: Re: [PATCH net-next 3/6] bridge: vlan: use synchronize_net() when
 holding RTNL

On 2/9/24 17:30, Eric Dumazet wrote:
> br_vlan_flush() and nbp_vlan_flush() should use synchronize_net()
> instead of syncronize_rcu() to release RTNL sooner.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>   net/bridge/br_vlan.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c
> index 15f44d026e75a8818f958703c5ec054eaafc4d94..9c2fffb827ab195cf9a01281e4790361e0b14bfe 100644
> --- a/net/bridge/br_vlan.c
> +++ b/net/bridge/br_vlan.c
> @@ -841,7 +841,7 @@ void br_vlan_flush(struct net_bridge *br)
>   	vg = br_vlan_group(br);
>   	__vlan_flush(br, NULL, vg);
>   	RCU_INIT_POINTER(br->vlgrp, NULL);
> -	synchronize_rcu();
> +	synchronize_net();
>   	__vlan_group_free(vg);
>   }
>   
> @@ -1372,7 +1372,7 @@ void nbp_vlan_flush(struct net_bridge_port *port)
>   	vg = nbp_vlan_group(port);
>   	__vlan_flush(port->br, port, vg);
>   	RCU_INIT_POINTER(port->vlgrp, NULL);
> -	synchronize_rcu();
> +	synchronize_net();
>   	__vlan_group_free(vg);
>   }
>   

Also CCed Roopa. Thanks,
Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>