netdev - RE: [Intel-wired-lan] [PATCH iwl-net] i40e: Fix wrong mask used during DCB config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CYYPR11MB8429C9D869C69C249F02AC5FBD4B2@CYYPR11MB8429.namprd11.prod.outlook.com>
Date: Fri, 9 Feb 2024 18:57:09 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: ivecera <ivecera@...hat.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "moderated list:INTEL ETHERNET DRIVERS"
	<intel-wired-lan@...ts.osuosl.org>, "Brandeburg, Jesse"
	<jesse.brandeburg@...el.com>, "Kubalewski, Arkadiusz"
	<arkadiusz.kubalewski@...el.com>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>, Eric Dumazet <edumazet@...gle.com>, "Nguyen,
 Anthony L" <anthony.l.nguyen@...el.com>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>,
	open list <linux-kernel@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net] i40e: Fix wrong mask used
 during DCB config

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Ivan Vecera
> Sent: Friday, December 1, 2023 1:02 AM
> To: netdev@...r.kernel.org
> Cc: moderated list:INTEL ETHERNET DRIVERS <intel-wired-lan@...ts.osuosl.org>; Brandeburg, Jesse <jesse.brandeburg@...el.com>; Kubalewski, Arkadiusz <arkadiusz.kubalewski@...el.com>; Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Eric Dumazet <edumazet@...gle.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; David S. Miller <davem@...emloft.net>; open list <linux-kernel@...r.kernel.org>
> Subject: [Intel-wired-lan] [PATCH iwl-net] i40e: Fix wrong mask used during DCB config
>
> Mask used for clearing PRTDCB_RETSTCC register in function
> i40e_dcb_hw_rx_ets_bw_config() is incorrect as there is used
> define I40E_PRTDCB_RETSTCC_ETSTC_SHIFT instead of define
> I40E_PRTDCB_RETSTCC_ETSTC_MASK.
>
> The PRTDCB_RETSTCC register is used to configure whether ETS
> or strict priority is used as TSA in Rx for particular TC.
>
> In practice it means that once the register is set to use ETS
> as TSA then it is not possible to switch back to strict priority
> without CoreR reset.
>
> Fix the value in the clearing mask.
>
> Fixes: 90bc8e003be2 ("i40e: Add hardware configuration for software based DCB")
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_dcb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)