netdev - Re: [PATCH] net: sched: Remove NET_ACT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMmc0fVegqtYKDZvBbfFjUSh-fEBPi+Nzjoz++CLAO5qPw@mail.gmail.com>
Date: Fri, 9 Feb 2024 13:56:34 -0500
From: Jamal Hadi Salim <jhs@...atatu.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc: Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, darren.kenny@...cle.com
Subject: Re: [PATCH] net: sched: Remove NET_ACT_IPT from Kconfig

On Fri, Feb 9, 2024 at 1:07 PM Harshit Mogalapalli
<harshit.m.mogalapalli@...cle.com> wrote:
>
> After this commit ba24ea129126 ("net/sched: Retire ipt action")
> NET_ACT_IPT is not needed anymore as the action is retired and the code
> is removed.
>
> Clean the Kconfig part as well.
>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal

> ---
> This is just based on observation.
>
>  net/sched/Kconfig | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/net/sched/Kconfig b/net/sched/Kconfig
> index 470c70deffe2..8180d0c12fce 100644
> --- a/net/sched/Kconfig
> +++ b/net/sched/Kconfig
> @@ -737,16 +737,6 @@ config NET_ACT_SAMPLE
>           To compile this code as a module, choose M here: the
>           module will be called act_sample.
>
> -config NET_ACT_IPT
> -       tristate "IPtables targets"
> -       depends on NET_CLS_ACT && NETFILTER && NETFILTER_XTABLES
> -       help
> -         Say Y here to be able to invoke iptables targets after successful
> -         classification.
> -
> -         To compile this code as a module, choose M here: the
> -         module will be called act_ipt.
> -
>  config NET_ACT_NAT
>         tristate "Stateless NAT"
>         depends on NET_CLS_ACT
> --
> 2.39.3
>