[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202402100218.Gmr6NGqc-lkp@intel.com>
Date: Sat, 10 Feb 2024 03:13:31 +0800
From: kernel test robot <lkp@...el.com>
To: Eric Dumazet <edumazet@...gle.com>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
eric.dumazet@...il.com, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH v2 net-next 10/13] net: add netdev_set_operstate() helper
Hi Eric,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/net-annotate-data-races-around-dev-name_assign_type/20240208-222037
base: net-next/main
patch link: https://lore.kernel.org/r/20240208141154.1131622-11-edumazet%40google.com
patch subject: [PATCH v2 net-next 10/13] net: add netdev_set_operstate() helper
config: sh-sh2007_defconfig (https://download.01.org/0day-ci/archive/20240210/202402100218.Gmr6NGqc-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240210/202402100218.Gmr6NGqc-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402100218.Gmr6NGqc-lkp@intel.com/
All errors (new ones prefixed by >>):
sh4-linux-ld: net/core/rtnetlink.o: in function `set_operstate':
>> net/core/rtnetlink.c:873:(.text+0x1140): undefined reference to `__cmpxchg_called_with_bad_pointer'
sh4-linux-ld: net/core/rtnetlink.o: in function `netdev_set_operstate':
net/core/rtnetlink.c:855:(.text+0x16d0): undefined reference to `__cmpxchg_called_with_bad_pointer'
vim +873 net/core/rtnetlink.c
93582d8ffc1ff5 Eric Dumazet 2024-02-08 857
93b2d4a208eeb1 David S. Miller 2008-02-17 858 static void set_operstate(struct net_device *dev, unsigned char transition)
b00055aacdb172 Stefan Rompf 2006-03-20 859 {
93582d8ffc1ff5 Eric Dumazet 2024-02-08 860 unsigned char operstate = READ_ONCE(dev->operstate);
b00055aacdb172 Stefan Rompf 2006-03-20 861
b00055aacdb172 Stefan Rompf 2006-03-20 862 switch (transition) {
b00055aacdb172 Stefan Rompf 2006-03-20 863 case IF_OPER_UP:
b00055aacdb172 Stefan Rompf 2006-03-20 864 if ((operstate == IF_OPER_DORMANT ||
eec517cdb4810b Andrew Lunn 2020-04-20 865 operstate == IF_OPER_TESTING ||
b00055aacdb172 Stefan Rompf 2006-03-20 866 operstate == IF_OPER_UNKNOWN) &&
eec517cdb4810b Andrew Lunn 2020-04-20 867 !netif_dormant(dev) && !netif_testing(dev))
b00055aacdb172 Stefan Rompf 2006-03-20 868 operstate = IF_OPER_UP;
b00055aacdb172 Stefan Rompf 2006-03-20 869 break;
b00055aacdb172 Stefan Rompf 2006-03-20 870
eec517cdb4810b Andrew Lunn 2020-04-20 871 case IF_OPER_TESTING:
abbc79280abc5e Juhee Kang 2022-08-31 872 if (netif_oper_up(dev))
eec517cdb4810b Andrew Lunn 2020-04-20 @873 operstate = IF_OPER_TESTING;
eec517cdb4810b Andrew Lunn 2020-04-20 874 break;
eec517cdb4810b Andrew Lunn 2020-04-20 875
b00055aacdb172 Stefan Rompf 2006-03-20 876 case IF_OPER_DORMANT:
abbc79280abc5e Juhee Kang 2022-08-31 877 if (netif_oper_up(dev))
b00055aacdb172 Stefan Rompf 2006-03-20 878 operstate = IF_OPER_DORMANT;
b00055aacdb172 Stefan Rompf 2006-03-20 879 break;
3ff50b7997fe06 Stephen Hemminger 2007-04-20 880 }
b00055aacdb172 Stefan Rompf 2006-03-20 881
93582d8ffc1ff5 Eric Dumazet 2024-02-08 882 netdev_set_operstate(dev, operstate);
b00055aacdb172 Stefan Rompf 2006-03-20 883 }
b00055aacdb172 Stefan Rompf 2006-03-20 884
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists