netdev - Re: [PATCH v8 net-next 0/4] add multi-buff support for xdp running in generic mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZcadZx1IMoB9xgG8@lore-desk>
Date: Fri, 9 Feb 2024 22:47:19 +0100
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, lorenzo.bianconi@...hat.com,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	bpf@...r.kernel.org, toke@...hat.com,
	willemdebruijn.kernel@...il.com, jasowang@...hat.com,
	sdf@...gle.com, hawk@...nel.org, ilias.apalodimas@...aro.org,
	linyunsheng@...wei.com
Subject: Re: [PATCH v8 net-next 0/4] add multi-buff support for xdp running
 in generic mode

> On Mon,  5 Feb 2024 12:35:11 +0100 Lorenzo Bianconi wrote:
> > Introduce multi-buffer support for xdp running in generic mode not always
> > linearizing the skb in netif_receive_generic_xdp routine.
> > Introduce generic percpu page_pools allocator.
> 
> breaks the veth test, apparently:
> 
> https://netdev-3.bots.linux.dev/vmksft-net/results/458181/60-veth-sh/stdout
> 
> could be that the test needs fixing not the code.
> But either way we need a respin :(
> -- 
> pw-bot: cr

Hi Jakub,

Ack, thx for reporting the problem. The issue is we should use skb_pp_cow_data()
instead of skb_cow_data_for_xdp() in veth_convert_skb_to_xdp_buff() since we do
not have any requirement for the attached bpf_prog there. I will fix it in v9.

Regards,
Lorenzo

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)