netdev - Re: [PATCH v2 net-next 01/10] ionic: minimal work with 0 budget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74e32f18-d0ee-4f55-99a5-5d47f1017a24@amd.com>
Date: Fri, 9 Feb 2024 15:33:45 -0800
From: "Nelson, Shannon" <shannon.nelson@....com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, brett.creeley@....com, drivers@...sando.io
Subject: Re: [PATCH v2 net-next 01/10] ionic: minimal work with 0 budget

On 2/9/2024 2:09 PM, Jakub Kicinski wrote:
> 
> On Wed, 7 Feb 2024 16:57:16 -0800 Shannon Nelson wrote:
>> We should be doing as little as possible besides freeing Tx
>> space when our napi routines are called with budget of 0, so
>> jump out before doing anything besides Tx cleaning.
>>
>> See commit afbed3f74830 ("net/mlx5e: do as little as possible in napi
>> poll when budget is 0") for more info.
> 
> Unfortunately to commit you quote proves that this is a real bug which
> can crash a non trivial number of machines if kernel printks meet an XDP
> workload :( This really should go to net.

Sure - I'll repackage that and send it back out.

sln