netdev - Re: [PATCH] brcmfmac: Remove unnecessary NULL-check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87il2uf8gi.fsf@kernel.org>
Date: Mon, 12 Feb 2024 09:27:41 +0200
From: Kalle Valo <kvalo@...nel.org>
To: Arend van Spriel <arend.vanspriel@...adcom.com>
Cc: Daniil Dulov <d.dulov@...ddin.ru>,  "David S. Miller"
 <davem@...emloft.net>,  Jakub Kicinski <kuba@...nel.org>,  Pieter-Paul
 Giesberts <pieterpg@...adcom.com>,  "Franky (Zhenhui) Lin"
 <frankyl@...adcom.com>,  "John W. Linville" <linville@...driver.com>,  Kan
 Yan <kanyan@...adcom.com>,  linux-wireless@...r.kernel.org,
  brcm80211-dev-list.pdl@...adcom.com,  SHA-cyfmac-dev-list@...ineon.com,
  netdev@...r.kernel.org,  linux-kernel@...r.kernel.org,
  lvc-project@...uxtesting.org
Subject: Re: [PATCH] brcmfmac: Remove unnecessary NULL-check.

Arend van Spriel <arend.vanspriel@...adcom.com> writes:

> On 2/11/2024 4:05 PM, Daniil Dulov wrote:
>> In this case req will never be NULL, so remove unnecessary check.
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Looks good to me, but when do we call things a "fix" and when is
> "improvement" more appropriate.
>
>> Fixes: 71bb244ba2fd ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets")
> Reviewed-by: Arend van Spriel <arend.vanspriel@...adcom.com>

Yeah, this is not a fix and the Fixes tag should be removed.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches