netdev - Re: [iwl-next v1 06/15] ice: add subfunction aux driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZctSU2cJHVwPhyhZ@nanopsycho>
Date: Tue, 13 Feb 2024 12:28:19 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	jacob.e.keller@...el.com, michal.kubiak@...el.com,
	maciej.fijalkowski@...el.com, sridhar.samudrala@...el.com,
	przemyslaw.kitszel@...el.com, wojciech.drewek@...el.com,
	pio.raczynski@...il.com,
	Piotr Raczynski <piotr.raczynski@...el.com>
Subject: Re: [iwl-next v1 06/15] ice: add subfunction aux driver support

Tue, Feb 13, 2024 at 10:43:00AM CET, michal.swiatkowski@...ux.intel.com wrote:
>On Tue, Feb 13, 2024 at 09:57:12AM +0100, Jiri Pirko wrote:
>> Tue, Feb 13, 2024 at 08:27:15AM CET, michal.swiatkowski@...ux.intel.com wrote:
>> >From: Piotr Raczynski <piotr.raczynski@...el.com>
>> >
>> >Instead of only registering devlink port by the ice driver itself,
>> >let PF driver only register port representor for a given subfunction.
>> >Then, aux driver is supposed to register its own devlink instance and
>> >register virtual devlink port.
>> >
>> >Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
>> >Signed-off-by: Piotr Raczynski <piotr.raczynski@...el.com>
>> >Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
>> >---
>> > .../intel/ice/devlink/ice_devlink_port.c      |  52 ++++-
>> > .../intel/ice/devlink/ice_devlink_port.h      |   6 +
>> > drivers/net/ethernet/intel/ice/ice_devlink.c  |  28 ++-
>> > drivers/net/ethernet/intel/ice/ice_devlink.h  |   3 +
>> > drivers/net/ethernet/intel/ice/ice_main.c     |   9 +
>> > drivers/net/ethernet/intel/ice/ice_sf_eth.c   | 214 ++++++++++++++++--
>> > drivers/net/ethernet/intel/ice/ice_sf_eth.h   |  21 ++
>> > 7 files changed, 302 insertions(+), 31 deletions(-)
>> 
>> Could you please split this. I see that you can push out 1-3 patches as
>> preparation.
>
>Do you mean 1-3 patchses from this patch, or from whole patchset? I mean,

This patch.

>do you want to split the patchset to two patchsets? (by splitting patch

Yes, 2 patchsets. If convenient 3. Just do one change per patch so it is
reviewable.


>from the patchset I will have more than netdev maximum; 15 I think). 
>
>Thanks,
>Michal