netdev - Re: [PATCH 2/2] phonet/pep: fix racy skb_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d64c2e241688f77a7a063b3f871f375ebc02be57.camel@redhat.com>
Date: Tue, 13 Feb 2024 13:14:36 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Rémi Denis-Courmont <remi@...lab.net>, 
 courmisch@...il.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] phonet/pep: fix racy skb_queue_empty() use

On Sat, 2024-02-10 at 14:50 +0200, Rémi Denis-Courmont wrote:
> From: Rémi Denis-Courmont <courmisch@...il.com>
> 
> The receive queues are protected by their respective spin-lock, not
> the socket lock. This could lead to skb_peek() unexpectedly
> returning NULL or a pointer to an already dequeued socket buffer.
> 
> Signed-off-by: Rémi Denis-Courmont <courmisch@...il.com>

Please provide a suitable fixes tag here.

Also include the target tree into the subj prefix when you post the v2.

Thank,

Paolo