netdev - Re: [PATCH 1/2] phonet: take correct lock to peek at the RX queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+g1mJK1E_DkVfugt5VVOsHvhivngmUMGW9apNZtF+eVA@mail.gmail.com>
Date: Tue, 13 Feb 2024 15:20:19 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Rémi Denis-Courmont <remi@...lab.net>
Cc: Paolo Abeni <pabeni@...hat.com>, courmisch@...il.com, davem@...emloft.net, 
	kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] phonet: take correct lock to peek at the RX queue

On Tue, Feb 13, 2024 at 1:55 PM Rémi Denis-Courmont <remi@...lab.net> wrote:
>
> Hi,
>
> Le 13 février 2024 14:12:57 GMT+02:00, Paolo Abeni <pabeni@...hat.com> a écrit :
> >On Sat, 2024-02-10 at 14:50 +0200, Rémi Denis-Courmont wrote:
> >> From: Rémi Denis-Courmont <courmisch@...il.com>
> >>
> >> Reported-by: Luosili <rootlab@...wei.com>
> >> Signed-off-by: Rémi Denis-Courmont <courmisch@...il.com>
> >
> >Looks good, but you need to add a non empty commit message.
>
> With all due respect, the headline is self-explanatory in my opinion. You can't compare this with the more involved second patch. Also the second patch was *not* reported by Huawei Rootlab, but inferred by me and thus has no existing documentation - unlike this one.
>
> As for the bug ID, I don't know it (security list didn't pass it on to me). Anyhow it seems that Eric Dumazet already either found it or filled it in, so I don't know what else you're asking for.

I do not think patchwork is able to add the "Fixes: " tag that I 'added'

And yes, I missed that the changelog was empty.

Some words would be nice, even if the patch looks obvious to few of us.