netdev - Re: [PATCH] [v2] net: sctp: fix skb leak in sctp_inq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADvbK_cjg7kd7uFWxPBpwMAxwsuCki791zQ7D01y+vk0R5wTSQ@mail.gmail.com>
Date: Tue, 13 Feb 2024 10:21:53 -0500
From: Xin Long <lucien.xin@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Dmitry Antipov <dmantipov@...dex.ru>, 
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, linux-sctp@...r.kernel.org, 
	netdev@...r.kernel.org, lvc-project@...uxtesting.org, 
	syzbot+8bb053b5d63595ab47db@...kaller.appspotmail.com
Subject: Re: [PATCH] [v2] net: sctp: fix skb leak in sctp_inq_free()

On Mon, Feb 12, 2024 at 7:25 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 12 Feb 2024 11:22:02 +0300 Dmitry Antipov wrote:
> > In case of GSO, 'chunk->skb' pointer may point to an entry from
> > fraglist created in 'sctp_packet_gso_append()'. To avoid freeing
> > random fraglist entry (and so undefined behavior and/or memory
> > leak), introduce 'sctp_chunk_release()' helper to ensure that
> > 'chunk->skb' is set to 'chunk->head_skb' (i.e. fraglist head)
> > before calling 'sctp_chunk_free()', and use the aforementioned
> > helper in 'sctp_inq_pop()' as well.
>
> Please repost this as a separate thread, per:
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#resending-after-review
and instead of sctp_chunk_release(), please use a better name like
"sctp_inq_chunk_free()" when you repost.

Thanks.

> Xin Long is probably out for New Year celebrations, anyway.
> --
> pw-bot: cr