netdev - Re: [PATCH net-next 2/3] net: ipv6/addrconf: introduce a regen_min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94aad0b2-142e-40eb-b81f-c98457bd1b58@kernel.org>
Date: Tue, 13 Feb 2024 08:36:13 -0700
From: David Ahern <dsahern@...nel.org>
To: Alex Henrie <alexhenrie24@...il.com>, netdev@...r.kernel.org,
 dan@...m.net, bagasdotme@...il.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, jikos@...nel.org
Subject: Re: [PATCH net-next 2/3] net: ipv6/addrconf: introduce a
 regen_min_advance sysctl

On 2/8/24 11:10 PM, Alex Henrie wrote:
> diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
> index 7afff42612e9..fcd6aa71b4fa 100644
> --- a/Documentation/networking/ip-sysctl.rst
> +++ b/Documentation/networking/ip-sysctl.rst
> @@ -2535,6 +2535,14 @@ max_desync_factor - INTEGER
>  
>  	Default: 600
>  
> +regen_min_advance - INTEGER
> +	How far in advance (in seconds), at minimum, to create a new temporary
> +	address before the current one is deprecated. This value is added to
> +	the amount of time that may be required for duplicate address detection
> +	to detemine when to create a new address.

s/detemine/determine/

Add some more comments here - e.g., RFC 8981 recommends a minimum of no
less than 2 seconds which is the default.

> +
> +	Default: 2
> +
>  regen_max_retry - INTEGER
>  	Number of attempts before give up attempting to generate
>  	valid temporary addresses.