netdev - Re: [PATCH net-next] net: sparx5: Add spinlock for frame transmission from CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5476743f-3648-4038-97f8-a9df22c0f507@gmail.com>
Date: Tue, 13 Feb 2024 09:26:45 -0800
From: Florian Fainelli <f.fainelli@...il.com>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 lars.povlsen@...rochip.com, Steen.Hegelund@...rochip.com,
 daniel.machon@...rochip.com, UNGLinuxDriver@...rochip.com
Cc: u.kleine-koenig@...gutronix.de, rmk+kernel@...linux.org.uk,
 vladimir.oltean@....com, jacob.e.keller@...el.com, yuehaibing@...wei.com,
 netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: sparx5: Add spinlock for frame transmission
 from CPU

On 2/13/24 04:17, Horatiu Vultur wrote:
> Both registers used when doing manual injection or fdma injection are
> shared between all the net devices of the switch. It was noticed that
> when having two process which each of them trying to inject frames on
> different ethernet ports, that the HW started to behave strange, by
> sending out more frames then expected. When doing fdma injection it is
> required to set the frame in the DCB and then make sure that the next
> pointer of the last DCB is invalid. But because there is no locks for
> this, then easily this pointer between the DCB can be broken and then it
> would create a loop of DCBs. And that means that the HW will
> continuously transmit these frames in a loop. Until the SW will break
> this loop.
> Therefore to fix this issue, add a spin lock for when accessing the
> registers for manual or fdma injection.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>

Any reason you targeted 'net-next' rather than 'net', as this appears to 
be clearly a bug fix here?
-- 
Florian