netdev - Re: [PATCH net-next] igc: Add support for LEDs on i225/i226

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a6ae4c1-2436-4909-bb20-32b91210803c@lunn.ch>
Date: Tue, 13 Feb 2024 19:49:21 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, netdev@...r.kernel.org,
	Kurt Kanzenbach <kurt@...utronix.de>, sasha.neftin@...el.com,
	Naama Meir <naamax.meir@...ux.intel.com>
Subject: Re: [PATCH net-next] igc: Add support for LEDs on i225/i226

On Tue, Feb 13, 2024 at 10:41:37AM -0800, Tony Nguyen wrote:
> From: Kurt Kanzenbach <kurt@...utronix.de>
> 
> Add support for LEDs on i225/i226. The LEDs can be controlled via sysfs
> from user space using the netdev trigger. The LEDs are named as
> igc-<bus><device>-<led> to be easily identified.
> 
> Offloading link speed and activity are supported. Other modes are simulated
> in software by using on/off. Tested on Intel i225.
> 
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Tested-by: Naama Meir <naamax.meir@...ux.intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>

Hi Tony

Did you change anything? I'm just wondering why you posted this,
rather than just giving an Acked-by:

       Andrew