| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <b3b50731-a364-425b-a0aa-c68c9f0f272a@gmail.com> Date: Tue, 13 Feb 2024 15:16:36 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Pawel Dembicki <paweldembicki@...il.com>, netdev@...r.kernel.org Cc: linus.walleij@...aro.org, Russell King <linux@...linux.org.uk>, Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Claudiu Manoil <claudiu.manoil@....com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, UNGLinuxDriver@...rochip.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next v4 01/15] net: dsa: vsc73xx: use read_poll_timeout instead delay loop On 2/13/24 14:03, Pawel Dembicki wrote: > This commit switches delay loop to read_poll_timeout macro during > Arbiter empty check in adjust link function. > > As Russel King suggested: > > "This [change] avoids the issue that on the last iteration, the code reads > the register, test it, find the condition that's being waiting for is > false, _then_ waits and end up printing the error message - that last > wait is rather useless, and as the arbiter state isn't checked after > waiting, it could be that we had success during the last wait." > > It also remove one short msleep delay. > > Suggested-by: Russell King <linux@...linux.org.uk> > Signed-off-by: Pawel Dembicki <paweldembicki@...il.com> > Reviewed-by: Andrew Lunn <andrew@...n.ch> Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com> -- Florian
Powered by blists - more mailing lists