netdev - Re: [PATCH v4 1/3] genetlink: Add per family bind/unbind callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22a264118ebe7194cf43a5d7e1d61417feff8534.camel@linux.intel.com>
Date: Mon, 12 Feb 2024 17:52:53 -0800
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: Jakub Kicinski <kuba@...nel.org>, Stanislaw Gruszka
	 <stanislaw.gruszka@...ux.intel.com>
Cc: linux-pm@...r.kernel.org, "Rafael J. Wysocki" <rafael@...nel.org>, 
 Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>, Daniel Lezcano
 <daniel.lezcano@...aro.org>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,  Jiri Pirko
 <jiri@...nulli.us>, Johannes Berg <johannes@...solutions.net>, Florian
 Westphal <fw@...len.de>,  netdev@...r.kernel.org
Subject: Re: [PATCH v4 1/3] genetlink: Add per family bind/unbind callbacks

On Mon, 2024-02-12 at 17:07 -0800, Jakub Kicinski wrote:
> On Mon, 12 Feb 2024 17:16:13 +0100 Stanislaw Gruszka wrote:
> > Add genetlink family bind()/unbind() callbacks when adding/removing
> > multicast group to/from netlink client socket via setsockopt() or
> > bind() syscall.
> > 
> > They can be used to track if consumers of netlink multicast
> > messages
> > emerge or disappear. Thus, a client implementing callbacks, can now
> > send events only when there are active consumers, preventing
> > unnecessary
> > work when none exist.
> > 
> > Suggested-by: Jakub Kicinski <kuba@...nel.org>
> > Signed-off-by: Stanislaw Gruszka
> > <stanislaw.gruszka@...ux.intel.com>
> 
> LGTM! genetlink code is a bit hot lately, to avoid any conflicts can
> I put the first patch (or all of them) on a shared branch for both
> netdev and PM to pull in? Once the other two patches are reviewed,
> obviously.
> 
If netlink maintainers are happy with the 1/3, you can take 1/3. Once
merged, the PM patches can go separately as they need 1/3.

Hi Daniel,
Please look at 2/3 and also 3/3 if you can.

Thanks,
Srinivas