netdev - Re: [PATCH net-next] net: ena: Remove redundant assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6bc5d27-c0e8-4292-a49b-5d5d609a5d60@amd.com>
Date: Mon, 12 Feb 2024 20:10:30 -0800
From: Brett Creeley <bcreeley@....com>
To: Kamal Heib <kheib@...hat.com>, netdev@...r.kernel.org,
 "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>
Cc: Shay Agroskin <shayagr@...zon.com>, David Arinzon <darinzon@...zon.com>
Subject: Re: [PATCH net-next] net: ena: Remove redundant assignment

On 2/12/2024 7:17 PM, Kamal Heib wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> There is no point in initializing an ndo to NULL, therefor the
> assignment is redundant and can be removed.
> 
> Signed-off-by: Kamal Heib <kheib@...hat.com>


Reviewed-by: Brett Creeley <brett.creeley@....com>

> ---
>   drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index 1c0a7828d397..88d7e785e10f 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -2867,7 +2867,6 @@ static const struct net_device_ops ena_netdev_ops = {
>          .ndo_get_stats64        = ena_get_stats64,
>          .ndo_tx_timeout         = ena_tx_timeout,
>          .ndo_change_mtu         = ena_change_mtu,
> -       .ndo_set_mac_address    = NULL, >          .ndo_validate_addr      = eth_validate_addr,
>          .ndo_bpf                = ena_xdp,
>          .ndo_xdp_xmit           = ena_xdp_xmit,
> --
> 2.43.0
> 
>