netdev - Re: [PATCH v3 net-next 06/13] net-sysfs: use dev_addr_sem to remove races in address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iKnMiAcp2h=RWjp52ucXkDMRJ7kbiiKqJ0iD_akVt3RCA@mail.gmail.com>
Date: Tue, 13 Feb 2024 07:08:23 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com
Subject: Re: [PATCH v3 net-next 06/13] net-sysfs: use dev_addr_sem to remove
 races in address_show()

On Tue, Feb 13, 2024 at 2:58 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri,  9 Feb 2024 20:34:21 +0000 Eric Dumazet wrote:
> > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> > index 24fd24b0f2341f662b28ade45ed12a5e6d02852a..28569f195a449700b6403006f70257b8194b516a 100644
> > --- a/include/linux/netdevice.h
> > +++ b/include/linux/netdevice.h
> > @@ -4031,6 +4031,7 @@ int dev_set_mac_address(struct net_device *dev, struct sockaddr *sa,
> >                       struct netlink_ext_ack *extack);
> >  int dev_set_mac_address_user(struct net_device *dev, struct sockaddr *sa,
> >                            struct netlink_ext_ack *extack);
> > +extern struct rw_semaphore dev_addr_sem;
>
> nit: this could potentially live in the net/core/dev.h header?

SGTM, I am taking a look.

>
> I could not spot any real problems but the series seems to not apply
> to net-next because of 4cd582ffa5a9a5d58e5bac9c5e55ca8eeabffddc

Right, of course, I will rebase and send v4, thanks !