netdev - Re: [PATCH net-next v2 1/3] net: ipv6/addrconf: ensure that regen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1833708b-6b3d-41b2-807b-864205578db7@kernel.org>
Date: Wed, 14 Feb 2024 08:38:57 -0700
From: David Ahern <dsahern@...nel.org>
To: Alex Henrie <alexhenrie24@...il.com>, netdev@...r.kernel.org,
 dan@...m.net, bagasdotme@...il.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, jikos@...nel.org
Subject: Re: [PATCH net-next v2 1/3] net: ipv6/addrconf: ensure that
 regen_advance is at least 2 seconds

On 2/13/24 11:26 PM, Alex Henrie wrote:
> RFC 8981 defines REGEN_ADVANCE as follows:
> 
> REGEN_ADVANCE = 2 + (TEMP_IDGEN_RETRIES * DupAddrDetectTransmits * RetransTimer / 1000)
> 
> Thus, allowing it to be less than 2 seconds is technically a protocol
> violation.
> 
> Link: https://datatracker.ietf.org/doc/html/rfc8981#name-defined-protocol-parameters
> Signed-off-by: Alex Henrie <alexhenrie24@...il.com>
> ---
>  Documentation/networking/ip-sysctl.rst |  4 ++--
>  net/ipv6/addrconf.c                    | 15 +++++++++------
>  2 files changed, 11 insertions(+), 8 deletions(-)
> 

Alex: if no changes are made to a specific patch, then you should keep
any reviewed by tags on the next version.

Reviewed-by: David Ahern <dsahern@...nel.org>