netdev - Re: [PATCH net-next] net: page_pool: make page_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240214101450.25ee7e5d@kernel.org>
Date: Wed, 14 Feb 2024 10:14:50 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: netdev@...r.kernel.org, lorenzo.bianconi@...hat.com,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 hawk@...nel.org, ilias.apalodimas@...aro.org
Subject: Re: [PATCH net-next] net: page_pool: make page_pool_create inline

On Wed, 14 Feb 2024 19:01:28 +0100 Lorenzo Bianconi wrote:
> Make page_pool_create utility routine inline a remove exported symbol.

But why? If you add the kdoc back the LoC saved will be 1.

>  include/net/page_pool/types.h |  6 +++++-
>  net/core/page_pool.c          | 10 ----------
>  2 files changed, 5 insertions(+), 11 deletions(-)

No strong opinion, but if you want to do it please put the helper 
in helpers.h  Let's keep the static inlines clearly separated.