netdev - Re: [PATCH v4 net-next 4/9] ionic: add initial framework for XDP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3cf1629a-a106-47e2-a75c-b299beae755b@intel.com>
Date: Wed, 14 Feb 2024 14:03:16 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Shannon Nelson <shannon.nelson@....com>, <netdev@...r.kernel.org>,
	<davem@...emloft.net>, <kuba@...nel.org>, <edumazet@...gle.com>,
	<pabeni@...hat.com>
CC: <brett.creeley@....com>, <drivers@...sando.io>
Subject: Re: [PATCH v4 net-next 4/9] ionic: add initial framework for XDP
 support



On 2/14/2024 9:59 AM, Shannon Nelson wrote:
> index cd3c0b01402e..98df2ee11c51 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> @@ -721,6 +721,11 @@ static int ionic_set_channels(struct net_device *netdev,
>  
>  	ionic_init_queue_params(lif, &qparam);
>  
> +	if ((ch->rx_count || ch->tx_count) && lif->xdp_prog) {
> +		netdev_info(lif->netdev, "Split Tx/Rx interrupts not available when using XDP\n");
> +		return -EOPNOTSUPP;
> +	}
> +

Not your fault but it would be nice if set_channels took an extack when
operating over ethtool netlink so that this error could be properly
reported.

I don't think that sort of refactor should hold XDP support though, so:

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>