netdev - Re: [Intel-wired-lan] [PATCH net-next v2 5/8] net: intel: i40e/igc: Remove setting Autoneg in EEE capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c5fb62b-1414-4547-bbb2-93d0ca866c89@intel.com>
Date: Wed, 14 Feb 2024 16:00:10 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Andrew Lunn <andrew@...n.ch>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, Ariel Elior <aelior@...vell.com>, Manish Chopra
	<manishc@...vell.com>, Jesse Brandeburg <jesse.brandeburg@...el.com>, "Tony
 Nguyen" <anthony.l.nguyen@...el.com>
CC: <netdev@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<intel-wired-lan@...ts.osuosl.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next v2 5/8] net: intel: i40e/igc:
 Remove setting Autoneg in EEE capabilities



On 2/14/2024 3:13 PM, Andrew Lunn wrote:
> Energy Efficient Ethernet should always be negotiated with the link
> peer. Don't include SUPPORTED_Autoneg in the results of get_eee() for
> supported, advertised or lp_advertised, since it is
> assumed. Additionally, ethtool(1) ignores the set bit, and no other
> driver sets this.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---

I checked the git blame for both igc, and i40e both in-tree and in our
out-of-tree drivers which have this code. There is no explanation given
and it was just part of the original commits for implementing EEE
support for these two drivers.

I can't find any trace of a justification for this.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>