netdev - RE: [PATCH net-next] net: ena: Remove unlikely() from IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eeb88c77389d4c51b3b35924e3fe8e4d@amazon.com>
Date: Wed, 14 Feb 2024 07:51:46 +0000
From: "Kiyanovski, Arthur" <akiyano@...zon.com>
To: Kamal Heib <kheib@...hat.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>, "Jakub
 Kicinski" <kuba@...nel.org>
CC: "Agroskin, Shay" <shayagr@...zon.com>, "Arinzon, David"
	<darinzon@...zon.com>
Subject: RE: [PATCH net-next] net: ena: Remove unlikely() from IS_ERR() condition



> -----Original Message-----
> From: Kamal Heib <kheib@...hat.com>
> Sent: Tuesday, February 13, 2024 6:15 PM
> To: netdev@...r.kernel.org; David S . Miller <davem@...emloft.net>; Jakub
> Kicinski <kuba@...nel.org>
> Cc: Agroskin, Shay <shayagr@...zon.com>; Arinzon, David
> <darinzon@...zon.com>; Kamal Heib <kheib@...hat.com>
> Subject: [EXTERNAL] [PATCH net-next] net: ena: Remove unlikely() from
> IS_ERR() condition
> 
> 
> 
> IS_ERR() is already using unlikely internally.
> 
> Signed-off-by: Kamal Heib <kheib@...hat.com>
> ---
>  drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index 03be2c008c4d..10e70d869cce 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -545,7 +545,7 @@ static int ena_alloc_rx_buffer(struct ena_ring
> *rx_ring,
> 
>         /* We handle DMA here */
>         page = ena_alloc_map_page(rx_ring, &dma);
> -       if (unlikely(IS_ERR(page)))
> +       if (IS_ERR(page))
>                 return PTR_ERR(page);
> 
>         netif_dbg(rx_ring->adapter, rx_status, rx_ring->netdev,
> --
> 2.43.0
> 

Thanks for submitting this patch.

Acked-by: Arthur Kiyanovski <akiyano@...zon.com>