netdev - Re: [PATCH net-next v5 00/11] introduce drop reasons for tcp receive path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoCvZE4F=Br5UgXzp7cQORNMAB8gVMnZm5QT-xXdqD9=AA@mail.gmail.com>
Date: Thu, 15 Feb 2024 19:10:15 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	dsahern@...nel.org, kuniyu@...zon.com, netdev@...r.kernel.org, 
	Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next v5 00/11] introduce drop reasons for tcp receive path

On Thu, Feb 15, 2024 at 6:12 PM Paolo Abeni <pabeni@...hat.com> wrote:
>
> Hi,
>
> On Thu, 2024-02-15 at 09:20 +0800, Jason Xing wrote:
> > From: Jason Xing <kernelxing@...cent.com>
> >
> > When I was debugging the reason about why the skb should be dropped in
> > syn cookie mode, I found out that this NOT_SPECIFIED reason is too
> > general. Thus I decided to refine it.
> >
> > v5:
> > Link: https://lore.kernel.org/netdev/20240213134205.8705-1-kerneljasonxing@gmail.com/
> > Link: https://lore.kernel.org/netdev/20240213140508.10878-1-kerneljasonxing@gmail.com/
> > 1. Use SKB_DROP_REASON_IP_OUTNOROUTES instead of introducing a new
> >    one (Eric, David)
> > 2. Reuse SKB_DROP_REASON_NOMEM to handle failure of request socket
> >    allocation (Eric)
> > 3. Reuse NO_SOCKET instead of introducing COOKIE_NOCHILD
> > 4. avoid duplication of these opt_skb tests/actions (Eric)
> > 5. Use new name (TCP_ABORT_ON_DATA) for readability (David)
> > 6. Reuse IP_OUTNOROUTES instead of INVALID_DST (Eric)
>
> It looks like this is causing a lot of self-test failures:
>
> https://netdev.bots.linux.dev/contest.html?pw-n=0&branch=net-next-2024-02-15--06-00&pass=0&skip=0
>
> due to tcp connect timeout, e.g.:
>
> https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/466281/9-tcp-fastopen-backup-key-sh/stdout
>
> please have look.

Thanks for your report. I double checked the series and found out my
new version of patch [4/11] is wrong. I will fix that.

I will continue to check the logic of the rest.

Thanks,
Jason

>
> Thanks!
>
> Paolo
>