netdev - Re: [PATCH net] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce2c5ee0-3bed-490e-ac57-58e849ec1eee@siemens.com>
Date: Thu, 15 Feb 2024 12:44:54 +0000
From: Diogo Ivo <diogo.ivo@...mens.com>
To: danishanwar@...com, rogerq@...nel.org, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, andrew@...n.ch,
 vigneshr@...com, jan.kiszka@...mens.com, dan.carpenter@...aro.org,
 robh@...nel.org, grygorii.strashko@...com, horms@...nel.org,
 diogo.ivo@...mens.com
Cc: linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: ti: icssg-prueth: Remove duplicate cleanup calls
 in emac_ndo_stop()


On 2/6/24 15:20, Diogo Ivo wrote:
> Remove the duplicate calls to prueth_emac_stop() and
> prueth_cleanup_tx_chns() in emac_ndo_stop().
>
> Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
> Fixes: 186734c15886 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
> Signed-off-by: Diogo Ivo <diogo.ivo@...mens.com>
> ---
>   drivers/net/ethernet/ti/icssg/icssg_prueth.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> index 411898a4f38c..cf7b73f8f450 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> @@ -1489,9 +1489,6 @@ static int emac_ndo_stop(struct net_device *ndev)
>   	/* Destroying the queued work in ndo_stop() */
>   	cancel_delayed_work_sync(&emac->stats_work);
>   
> -	/* stop PRUs */
> -	prueth_emac_stop(emac);
> -
>   	if (prueth->emacs_initialized == 1)
>   		icss_iep_exit(emac->iep);
>   
> @@ -1502,7 +1499,6 @@ static int emac_ndo_stop(struct net_device *ndev)
>   
>   	free_irq(emac->rx_chns.irq[rx_flow], emac);
>   	prueth_ndev_del_tx_napi(emac, emac->tx_ch_num);
> -	prueth_cleanup_tx_chns(emac);
>   
>   	prueth_cleanup_rx_chns(emac, &emac->rx_chns, max_rx_flows);
>   	prueth_cleanup_tx_chns(emac);

Hello,

Gentle ping on this patch.


Thank you,

Diogo