netdev - Re: [PATCH net-next v3 10/17] dt-bindings: net: pse-pd: Add another way of describing several PSE PIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240215135130.GA4139246-robh@kernel.org>
Date: Thu, 15 Feb 2024 07:51:30 -0600
From: Rob Herring <robh@...nel.org>
To: Köry Maincent <kory.maincent@...tlin.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jonathan Corbet <corbet@....net>,
	Luis Chamberlain <mcgrof@...nel.org>,
	Russ Weight <russ.weight@...ux.dev>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	Mark Brown <broonie@...nel.org>,
	Frank Rowand <frowand.list@...il.com>, Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, devicetree@...r.kernel.org,
	Dent Project <dentproject@...uxfoundation.org>
Subject: Re: [PATCH net-next v3 10/17] dt-bindings: net: pse-pd: Add another
 way of describing several PSE PIs

On Wed, Feb 14, 2024 at 04:41:50PM +0100, Köry Maincent wrote:
> On Wed, 14 Feb 2024 14:13:10 +0100
> Köry Maincent <kory.maincent@...tlin.com> wrote:
> 
> > Hello Rob,
> > 
> > Thanks for your review!
> > 
> > On Fri, 9 Feb 2024 14:43:49 +0000
> > Rob Herring <robh@...nel.org> wrote:
> > 
> > > On Thu, Feb 08, 2024 at 02:08:47PM +0100, Kory Maincent wrote:  
> > > > Before hand we set "#pse-cell" to 1 to define a PSE controller with    
> > > 
> > > #pse-cells
> > >   
> > > > several PIs (Power Interface). The drawback of this was that we could not
> > > > have any information on the PI except its number.    
> > > 
> > > Then increase it to what you need. The whole point of #foo-cells is that 
> > > it is variable depending on what the provider needs. 
> > >   
> > > > Add support for pse_pis and pse_pi node to be able to have more
> > > > information on the PI like the number of pairset used and the pairset
> > > > pinout.    
> > > 
> > > Please explain the problem you are trying to solve, not your solution. I 
> > > don't understand what the problem is to provide any useful suggestions 
> > > on the design.  
> > 
> > Please see Oleksij's reply.
> > Thank you Oleksij, for the documentation!!
> > 
> > > > 
> > > > Sponsored-by: Dent Project <dentproject@...uxfoundation.org>    
> > > 
> > > Is this a recognized tag? First I've seen it.  
> > 
> > This is not a standard tag but it has been used several times in the past.
> 
> Not so much used indeed:
> $ git log --grep="Sponsored" | grep Sponsored     
>     Sponsored by:  The FreeBSD Foundation
>     Sponsored by:  The FreeBSD Foundation
>     Sponsored by:  The FreeBSD Foundation
>     Sponsored by:  The FreeBSD Foundation
>     Sponsored-by: Google Chromium project
>     Sponsored: Google ChromeOS
>     Sponsored: Google ChromeOS
> 
> Is it ok to keep it?

IMO, its use should be documented like other tags, or it should not be 
used. Just write a sentence to the same effect.

Rob