netdev - Re: [PATCH ethtool] ethtool: put driver specific code into drivers dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23bdba44-0a82-428f-b813-3675b2da1984@lunn.ch>
Date: Thu, 15 Feb 2024 15:40:27 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Denis Kirjanov <dkirjanov@...e.de>
Cc: Denis Kirjanov <kirjanov@...il.com>, mkubecek@...e.cz,
	netdev@...r.kernel.org
Subject: Re: [PATCH ethtool] ethtool: put driver specific code into drivers
 dir

On Thu, Feb 15, 2024 at 04:41:47PM +0300, Denis Kirjanov wrote:
> 
> 
> On 2/14/24 21:12, Andrew Lunn wrote:
> > On Wed, Feb 14, 2024 at 08:55:05AM -0500, Denis Kirjanov wrote:
> >> the patch moves the driver specific code in drivers
> >> directory
> > 
> > It is normal for the commit message to give the answer to the question
> > "Why?".
> 
> "For better code organization the patch moves the driver-specific code into drivers directory"

Is that enough justify the code churn? Are you about to add a lot more
driver code?

> > Also, what is your definition of a driver? I would not really call the
> > sfp parts drivers.
> 
> Sure, I'll put them back in the next version

It is i while since i looked at the insides of ethtool. But if i
remember correctly, the 'drivers' are there to pretty print values
returned by ethtool --register-dump. SFP was just an example, i
suspect there are other files which you moved which are not used by
register-dump as drivers. Hence my question, what is your definition
of driver?

   Andrew