netdev - Re: [PATCH net] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c143cfbf-c474-42b8-adbb-13676e177d34@siemens.com>
Date: Thu, 15 Feb 2024 15:10:45 +0000
From: Diogo Ivo <diogo.ivo@...mens.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: danishanwar@...com, rogerq@...nel.org, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, vigneshr@...com,
 jan.kiszka@...mens.com, dan.carpenter@...aro.org, robh@...nel.org,
 grygorii.strashko@...com, horms@...nel.org,
 linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
 diogo.ivo@...mens.com
Subject: Re: [PATCH net] net: ti: icssg-prueth: Remove duplicate cleanup calls
 in emac_ndo_stop()


On 2/15/24 14:53, Andrew Lunn wrote:
>> Hello,
>>
>> Gentle ping on this patch.
> Gentle ping's don't work for netdev. Merging patches is pretty much
> driver by patchwork, so it is good to look there and see the state of
> the patch.
>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fnetdevbpf%2Fpatch%2F20240206152052.98217-1-diogo.ivo%40siemens.com%2F&data=05%7C02%7Cdiogo.ivo%40siemens.com%7Cc6a5a844ef59437e85f308dc2e35cb4b%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C638436055786669669%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=CMjL%2Bkc9%2BOo0igLSnX4OzgxO3CGKP2m67afScU0pG0I%3D&reserved=0
>
> This is marked as Changes Requested.
>
> Looking at the discussion, it seemed to conclude this is a cleanup,
> not a fix. Hence the two Fixes: probably want removing.
>
> Please repost with them removed, and the Reviewed-by's added.
>
> You should also set the patch subject to include [net-next] to
> indicate which tree this patch is for:
>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.kernel.org%2Fdoc%2Fhtml%2Flatest%2Fprocess%2Fmaintainer-netdev.html%23netdev-faq&data=05%7C02%7Cdiogo.ivo%40siemens.com%7Cc6a5a844ef59437e85f308dc2e35cb4b%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C638436055786678320%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=ZS2Gn%2F9kqM7UKL9VD8mSCXeegsx%2BXI6jvgW30XoqQ2M%3D&reserved=0
>
>         Andrew

Ok, thank you for the clarification!

I'll prepare the patch as requested.


Thanks,

Diogo