[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240215152203.431268-1-diogo.ivo@siemens.com>
Date: Thu, 15 Feb 2024 15:22:01 +0000
From: Diogo Ivo <diogo.ivo@...mens.com>
To: danishanwar@...com,
rogerq@...nel.org,
davem@...emloft.net,
edumazet@...gle.com,
kuba@...nel.org,
pabeni@...hat.com,
andrew@...n.ch,
jan.kiszka@...mens.com,
dan.carpenter@...aro.org,
robh@...nel.org
Cc: Diogo Ivo <diogo.ivo@...mens.com>,
linux-arm-kernel@...ts.infradead.org,
netdev@...r.kernel.org
Subject: [PATCH net-next v2] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop()
Remove the duplicate calls to prueth_emac_stop() and
prueth_cleanup_tx_chns() in emac_ndo_stop().
Signed-off-by: Diogo Ivo <diogo.ivo@...mens.com>
Reviewed-by: Roger Quadros <rogerq@...nel.org>
Reviewed-by: MD Danish Anwar <danishanwar@...com>
---
Changes in v2:
- Removed Fixes: tags
- Added Reviewed-by's
drivers/net/ethernet/ti/icssg/icssg_prueth.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index 411898a4f38c..cf7b73f8f450 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -1489,9 +1489,6 @@ static int emac_ndo_stop(struct net_device *ndev)
/* Destroying the queued work in ndo_stop() */
cancel_delayed_work_sync(&emac->stats_work);
- /* stop PRUs */
- prueth_emac_stop(emac);
-
if (prueth->emacs_initialized == 1)
icss_iep_exit(emac->iep);
@@ -1502,7 +1499,6 @@ static int emac_ndo_stop(struct net_device *ndev)
free_irq(emac->rx_chns.irq[rx_flow], emac);
prueth_ndev_del_tx_napi(emac, emac->tx_ch_num);
- prueth_cleanup_tx_chns(emac);
prueth_cleanup_rx_chns(emac, &emac->rx_chns, max_rx_flows);
prueth_cleanup_tx_chns(emac);
--
2.43.1
Powered by blists - more mailing lists