netdev - Re: [RFC net-next] net: page_pool: fix recycle stats for percpu page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zc4uZucrtv5dNt_1@lore-desk>
Date: Thu, 15 Feb 2024 16:31:50 +0100
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Alexander Lobakin <aleksander.lobakin@...el.com>,
	netdev@...r.kernel.org, lorenzo.bianconi@...hat.com,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	hawk@...nel.org, ilias.apalodimas@...aro.org,
	linyunsheng@...wei.com, toke@...hat.com
Subject: Re: [RFC net-next] net: page_pool: fix recycle stats for percpu
 page_pool allocator

> On Thu, 15 Feb 2024 14:41:52 +0100 Alexander Lobakin wrote:
> > For example, if I have an Rx queue always pinned to one CPU, I might
> > want to create a PP for this queue with the cpuid set already to save
> > some cycles when recycling. We might also reuse cpuid later for some
> > more optimizations or features.
> 
> You say "pin Rx queue to one CPU" like that's actually possible to do
> reliably :)
> 
> > Maybe add a new PP_FLAG indicating that system percpu PP stats should be
> > used?
> 
> Part of me feels like checking the dev pointer would be good enough.
> It may make sense to create more per CPU pools for particular devices
> further down, but creating more pools without no dev / DMA mapping
> makes no sense, right?
> 
> Dunno if looking at dev is not too hacky, tho, flags are cheap.

I would vote for a dedicated flag ;)

Regards,
Lorenzo

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)