netdev - Re: [PATCH v2] dt-bindings: net: renesas,ethertsn: Add Ethernet TSN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 17:03:33 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Cc: Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	devicetree@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: net: renesas,ethertsn: Add Ethernet TSN

Hi Niklas,

On Tue, Nov 21, 2023 at 7:38 PM Niklas Söderlund
<niklas.soderlund+renesas@...natech.se> wrote:
> Add bindings for Renesas R-Car Ethernet TSN End-station IP. The RTSN
> device provides Ethernet network.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>

Thanks for your patch, which is now commit c5b9f4792ea6b9ab
("dt-bindings: net: renesas,ethertsn: Add Ethernet TSN") in v6.8-rc1.

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/renesas,ethertsn.yaml

> +  interrupts:
> +    items:
> +      - description: TX data interrupt
> +      - description: RX data interrupt
> +
> +  interrupt-names:
> +    items:
> +      - const: tx
> +      - const: rx

What about the (17!) other interrupts?

> +  rx-internal-delay-ps:
> +    enum: [0, 1800]
> +
> +  tx-internal-delay-ps:
> +    enum: [0, 2000]

These two should either have a default, or be required (like on
EtherAVB, where we couldn't have a default because the absence of
 these properties is used to enable a legacy fallback).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds