netdev - Re: [PATCH v10 2/2] net/bnx2x: refactor common code to bnx2x_stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35386fe5-dfbc-4698-a4a8-6c6a2df454cf@linux.vnet.ibm.com>
Date: Thu, 15 Feb 2024 10:17:21 -0600
From: Thinh Tran <thinhtr@...ux.vnet.ibm.com>
To: Jacob Keller <jacob.e.keller@...el.com>, kuba@...nel.org
Cc: netdev@...r.kernel.org, davem@...emloft.net, manishc@...vell.com,
        pabeni@...hat.com, skalluru@...vell.com, simon.horman@...igine.com,
        edumazet@...gle.com, VENKATA.SAI.DUGGI@....com, drc@...ux.vnet.ibm.com,
        abdhalee@...ibm.com
Subject: Re: [PATCH v10 2/2] net/bnx2x: refactor common code to
 bnx2x_stop_nic()



On 2/14/2024 2:50 PM, Jacob Keller wrote:
> 
> Good cleanup.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
>
Thank you for the review.

> 
> IMHO this could be an early return:
> 
> if (bp->nic_stopped)
>      return;
> 
> That is a bit of a nitpick and the existing code (by necessity of not
> being a function) used this style.

and thank you for the suggestion. I will update the code to utilize an 
early return as you proposed.

Thanks,
Thinh Tran