netdev - Re: [PATCH] net: sfp: remove redundant NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4a7300f3-116a-4824-98c4-209a217a4a11@lunn.ch>
Date: Thu, 15 Feb 2024 18:32:06 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Daniil Dulov <d.dulov@...ddin.ru>,
	Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] net: sfp: remove redundant NULL check

> However, I'll go back to my original point: this is *not* something
> that automated tools should be identifying, and it is *not* something
> that should be used to throw patches randomly out, especially where
> the commit message doesn't include human analysis details.

Hi Daniil

Could you work on SVACE and make it dump how it decided it was safe to
remove the NULL check. I assume it found the path via
sfp_register_socket(), and the NULL check in that. So it should be
able to dump that info in some form. sfp_bus_add_upstream() seems more
interesting and it would be interesting to know why it though a NULL
from there was impossible.

It would be great if the tool dumped some text which could be
cut/paste into the commit message as a justification for the change.

	Andrew