[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240216104211.2c11d1cc@kmaincent-XPS-13-7390>
Date: Fri, 16 Feb 2024 10:42:11 +0100
From: Köry Maincent <kory.maincent@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet
<corbet@....net>, Luis Chamberlain <mcgrof@...nel.org>, Russ Weight
<russ.weight@...ux.dev>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J. Wysocki" <rafael@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
<conor+dt@...nel.org>, Oleksij Rempel <o.rempel@...gutronix.de>, Mark Brown
<broonie@...nel.org>, Frank Rowand <frowand.list@...il.com>, Andrew Lunn
<andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
<linux@...linux.org.uk>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org, devicetree@...r.kernel.org, Dent Project
<dentproject@...uxfoundation.org>
Subject: Re: [PATCH net-next v4 05/17] net: pse-pd: Introduce PSE types
enumeration
On Thu, 15 Feb 2024 10:58:46 -0800
Jakub Kicinski <kuba@...nel.org> wrote:
> On Thu, 15 Feb 2024 17:02:46 +0100 Kory Maincent wrote:
> > Introduce an enumeration to define PSE types (C33 or PoDL),
> > utilizing a bitfield for potential future support of both types.
> > Include 'pse_get_types' helper for external access to PSE type info.
>
> I haven't read the series, just noticed this breaks the build:
>
> error: ../include/uapi/linux/pse.h: missing "WITH Linux-syscall-note" for
> SPDX-License-Identifier
By curiosity how do you get that error?
Is it with C=1? I didn't faced it with W=1.
C=1 is broken for several architecture like arm64, indeed I forgot to run it.
> but why the separate header? Is it going to be used in other parts of
> uAPI than just in ethtool?
We might use it in pse core if capabilities between PoE and PoDL differ but I
am not sure about it.
Do you prefer to move it to ethtool header and add prefix ETHTOOL_ to the enum
values?
> > This patch is sponsored by Dent Project <dentproject@...uxfoundation.org>
>
> side-note: no objections to the line but for accounting purposes
> (i.e. when we generate development stats) we use the Author / From
> line exclusively. So it'd be easier to compute stats of things funded
> by Dent if you used:
>
> From: Kory Maincent (Dent Project) <kory.maincent@...tlin.com>
>
> but that's entirely up to you :)
Does adding the line side to the SOB in the commit message is sufficient or
should I modify the git send email config?
Regard,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
Powered by blists - more mailing lists