netdev - Re: [PATCH net v3 1/2] net/sched: act_mirred: use the backlog for mirred ingress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 16 Feb 2024 10:20:25 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, marcelo.leitner@...il.com, dcaratti@...hat.com,
 jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
 shmulik.ladkani@...il.com
Subject: Re: [PATCH net v3 1/2] net/sched: act_mirred: use the backlog for mirred
 ingress

Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@...emloft.net>:

On Thu, 15 Feb 2024 06:33:45 -0800 you wrote:
> The test Davide added in commit ca22da2fbd69 ("act_mirred: use the backlog
> for nested calls to mirred ingress") hangs our testing VMs every 10 or so
> runs, with the familiar tcp_v4_rcv -> tcp_v4_rcv deadlock reported by
> lockdep.
> 
> The problem as previously described by Davide (see Link) is that
> if we reverse flow of traffic with the redirect (egress -> ingress)
> we may reach the same socket which generated the packet. And we may
> still be holding its socket lock. The common solution to such deadlocks
> is to put the packet in the Rx backlog, rather than run the Rx path
> inline. Do that for all egress -> ingress reversals, not just once
> we started to nest mirred calls.
> 
> [...]

Here is the summary with links:
  - [net,v3,1/2] net/sched: act_mirred: use the backlog for mirred ingress
    https://git.kernel.org/netdev/net/c/52f671db1882
  - [net,v3,2/2] net/sched: act_mirred: don't override retval if we already lost the skb
    https://git.kernel.org/netdev/net/c/166c2c8a6a4d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html