netdev - Re: [PATCH net-next] ethtool: check for unsupported modes in EEE advertisement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50ad932c-4775-4201-b2ce-f5f21eaa966d@gmail.com>
Date: Fri, 16 Feb 2024 12:21:37 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Andrew Lunn <andrew@...n.ch>,
 "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
 David Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] ethtool: check for unsupported modes in EEE
 advertisement

On 16.02.2024 00:33, Andrew Lunn wrote:
> On Thu, Feb 15, 2024 at 03:53:40PM +0000, Russell King (Oracle) wrote:
>> On Thu, Feb 15, 2024 at 02:05:54PM +0100, Heiner Kallweit wrote:
>>> Let the core check whether userspace returned unsupported modes in the
>>> EEE advertisement bitmap. This allows to remove these checks from
>>> drivers.
>>
>> Why is this a good thing to implement?
>>
>> Concerns:
>> 1) This is a change of behaviour for those drivers that do not
>> implement this behaviour.
> 
> Hi Heiner
> 
> You say phylib does this by default? Are there any none phylib/phylink
> drivers which don't implement this behaviour?
> 
Very few drivers ignore unknown/unsupported modes:
bnx2, r8152, ax88179, igc
Basically the ones using ethtool_adv_to_mmd_eee_adv_t() on the userspace-provided
EEE advertisement. However for e.g. Intel drivers the behavior isn't consistent,
some of their drivers check for unsupported modes and bail out if found.

> 	Andrew
> 
Heiner