netdev - Re: [PATCH v2 4/6] dt-bindings: net: add hisilicon,hisi-femac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <170808424648.2323386.17364036307896639662.robh@kernel.org>
Date: Fri, 16 Feb 2024 05:50:47 -0600
From: Rob Herring <robh@...nel.org>
To: Yang Xiwen <forbidden405@...look.com>
Cc: netdev@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, 
 Russell King <linux@...linux.org.uk>, Eric Dumazet <edumazet@...gle.com>, 
 Yisen Zhuang <yisen.zhuang@...wei.com>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
 linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, 
 devicetree@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>, 
 Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>, 
 Rob Herring <robh+dt@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
 Salil Mehta <salil.mehta@...wei.com>, Yang Xiwen <forbidden405@...mail.com>
Subject: Re: [PATCH v2 4/6] dt-bindings: net: add hisilicon,hisi-femac

On Fri, 16 Feb 2024 18:02:03 +0800, Yang Xiwen wrote:
> This binding gets rewritten. Compared to previous txt based binding doc,
> the following changes are made according to the TRM:
> 
> - No "hisi-femac-v1/2" binding anymore
> - Remove unmaintained Hi3516 SoC, add Hi3798MV200
> - add MDIO subnode
> - add ahb bus clock, phy clock and reset
> 
> Signed-off-by: Yang Xiwen <forbidden405@...look.com>
> ---
>  .../bindings/net/hisilicon,hisi-femac.yaml         | 117 +++++++++++++++++++++
>  1 file changed, 117 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml:
Error in referenced schema matching $id: http://devicetree.org/schemas/net/hisilicon,hisi-femac-mdio.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.example.dtb: ethernet@...0000: mdio@...0: False schema does not allow {'compatible': ['hisilicon,hisi-femac-mdio'], 'reg': [[4352, 32]], '#address-cells': [[1]], '#size-cells': [[0]], 'status': ['okay'], 'ethernet-phy@1': {'reg': [[1]], '#phy-cells': [[0]]}}
	from schema $id: http://devicetree.org/schemas/net/hisilicon,hisi-femac.yaml#
Documentation/devicetree/bindings/net/hisilicon,hisi-femac.example.dtb: /example-0/ethernet@...0000/mdio@...0: failed to match any schema with compatible: ['hisilicon,hisi-femac-mdio']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240216-net-v2-4-89bd4b7065c2@outlook.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.