netdev - VLAN "issue" on STMMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <7cfc9562-161d-4d6c-a355-406938b3361e@foss.st.com>
Date: Fri, 16 Feb 2024 15:35:14 +0100
From: Christophe ROULLIER <christophe.roullier@...s.st.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, Alexandre Torgue <alexandre.torgue@...s.st.com>,
        <netdev@...r.kernel.org>
Subject: VLAN "issue" on STMMAC

Hello,

I've a question concerning following commit:

ed64639bc1e0899d89120b82af52e74fcbeebf6a :

net: stmmac: Add support for VLAN Rx filtering

Add support for VLAN ID-based filtering by the MAC controller for MAC

drivers that support it. Only the 12-bit VID field is used.

Signed-off-by: Chuah Kim Tatt kim.tatt.chuah@...el.com
Signed-off-by: Ong Boon Leong boon.leong.ong@...el.com
Signed-off-by: Wong Vee Khee vee.khee.wong@...el.com
Signed-off-by: David S. Miller davem@...emloft.net

So now with this commit is no more possible to create some VLAN than 
previously (it depends of number of HW Tx queue) (one VLAN max)

root@...32mp1:~# ip link add link end0 name end0.200 type vlan id 200
[   61.207767] 8021q: 802.1Q VLAN Support v1.8
[   61.210629] 8021q: adding VLAN 0 to HW filter on device end0
[   61.230515] stm32-dwmac 5800a000.ethernet end0: Adding VLAN ID 0 is 
not supported
root@...32mp1:~# ip link add link end0 name end0.300 type vlan id 300
[   71.403195] stm32-dwmac 5800a000.ethernet end0: Only single VLAN ID 
supported
RTNETLINK answers: Operation not permitted
root@...32mp1:~#

I've tried to deactivate VLAN filtering with ethtool, but not possible 
("fixed" value)

root@...32mp1:~# ethtool -k end0 | grep -i vlan
rx-vlan-offload: on [fixed]
tx-vlan-offload: on [fixed]
rx-vlan-filter: on [fixed]
vlan-challenged: off [fixed]
tx-vlan-stag-hw-insert: on [fixed]
rx-vlan-stag-hw-parse: on [fixed]
rx-vlan-stag-filter: on [fixed]
root@...32mp1:~#
root@...32mp1:~# ethtool -K end0 rxvlan off
Actual changes:
rx-vlan-hw-parse: on [requested off]
Could not change any device features

Do you know if there are possibility to force creation of VLAN ID (may 
be in full SW ?) and keep the rest of Ethernet Frame processing to GMAC HW.

Thanks for your help/feedback

Regards,

Christophe