[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240216172701.GP40273@kernel.org>
Date: Fri, 16 Feb 2024 17:27:01 +0000
From: Simon Horman <horms@...nel.org>
To: Daniil Dulov <d.dulov@...ddin.ru>
Cc: Wolfgang Grandegger <wg@...ndegger.com>,
Marc Kleine-Budde <mkl@...gutronix.de>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Kurt Van Dijck <dev.kurt@...dijck-laurijssen.be>,
linux-can@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] can: softing: remove redundant NULL check
On Sun, Feb 11, 2024 at 07:05:35AM -0800, Daniil Dulov wrote:
> In this case dev cannot be NULL, so remove redundant check.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 03fd3cf5a179 ("can: add driver for Softing card")
> Signed-off-by: Daniil Dulov <d.dulov@...ddin.ru>
Hi Daniil,
I am not sure that dev cannot be NULL.
But I do see that the code assumes it is not, and would crash if it is.
So I think that, functionally, your statement is correct.
priv = netdev_priv(dev);
card = priv->card;
Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists